Skip to content

set_meter_provider was being called twice which had the effect of completely disabling metrics. #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrynCooke merged 1 commit into from
Dec 9, 2022
Merged

set_meter_provider was being called twice which had the effect of completely disabling metrics. #2236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ By [@bryncooke](https://github.com/bryncooke) in https://github.com/apollographq

Update to OpenTelemetry 0.18.

By [@bryncooke](https://github.com/bryncooke) and [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/1970
By [@bryncooke](https://github.com/bryncooke) and [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/1970 and https://github.com/apollographql/router/pull/2236

### Remove spaceport ([Issue #2233](https://github.com/apollographql/router/issues/2233))

Expand Down
1 change: 0 additions & 1 deletion apollo-router/src/plugins/telemetry/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ impl Telemetry {
// we use the aggregate meter provider that is created below. It enables us to support
// sending metrics to multiple providers at once, of which hopefully Apollo Studio is one.
let mut builder = Self::create_metrics_exporters(&config)?;
opentelemetry::global::set_meter_provider(builder.meter_provider());

// the global tracer and subscriber initialization step must be performed only once
TELEMETRY_LOADED.get_or_try_init::<_, BoxError>(|| {
Expand Down