Redeploy router if mounted supergraph schema changes #2223
Merged
garypen merged 4 commits intoapollographql:devfrom Dec 12, 2022
Merged
Redeploy router if mounted supergraph schema changes #2223garypen merged 4 commits intoapollographql:devfrom
garypen merged 4 commits intoapollographql:devfrom
Conversation
…nted as a configmap
garypen
suggested changes
Dec 9, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
Great suggestion. I've requested a change to use annotation rather than label. Please update NEXT_CHANGELOG.md with an entry (it's a new FEATURE) to make sure you are correctly credited with the change in our release notes.
| labels: | ||
| {{- include "router.selectorLabels" . | nindent 8 }} | ||
| {{- if .Values.supergraphFile }} | ||
| checksum/supergraph: {{ .Values.supergraphFile | sha256sum | trunc 63 }} |
Contributor
There was a problem hiding this comment.
Suggested change
| checksum/supergraph: {{ .Values.supergraphFile | sha256sum | trunc 63 }} | |
| checksum/supergraph-config-map: {{ .Values.supergraphFile | sha256sum | trunc 63 }} |
One other thing: I usually see this done as an annotation rather than as a label. Could you make that change?
garypen
changed the title
garypen
approved these changes
Dec 12, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
Thanks very much for this submission.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off of @garypen's PR #2119, if the supergraphFile is set, add a label to the pods with a hash of its contents. This will force new pods to be spun up if the supergraphFile is changed so the new file will be loaded.