Conversation
added 16 commits
December 2, 2022 22:51
BrynCooke
force-pushed
the
bryn/automate-release
branch
from
30526b1 to
ef66693
Compare
added 2 commits
December 5, 2022 13:37
bnjjj
suggested changes
Dec 5, 2022
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
bnjjj
approved these changes
Dec 5, 2022
garypen
suggested changes
Dec 5, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
I think I spotted a typo.
garypen
approved these changes
Dec 5, 2022
SimonSapin
approved these changes
Dec 5, 2022
Contributor
wrong pr? |
Contributor
|
Yes 😅 |
Contributor
Author
|
I got an approval out of it though :) |
Merged
abernix
added a commit
that referenced
this pull request
Jan 4, 2023
This follows-up #2202 and it consists of several commits which can stand alone, if necessary. Each of those commits has their own message and while I suggest reviewing the totality of the PR, it's worth considering the text of the individual commit messages for additional context on the changes. As a summary of those commits: - Remove destructive `git reset --hard` command which destroyed my local changes - Require a pristine Git checkout of known files prior to releasing - Update Helm Chart version BEFORE `helm-docs` and `helm template` commands. - Do a pre-flight check which asserts availabilty of necessary tools - Remove pre-determined version heading from `NEXT_CHANGELOG.md` - Repair logic which migrates `NEXT_CHANGELOG.md` entries to `CHANGELOG.md` - Support ANY version string rather than just digits-dot-digits-dot-digits. - Remove quotes around invocation of `helm template`'s `--set` flags Contributes to #2261 Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
abernix
added a commit
that referenced
this pull request
Jan 16, 2023
Today, when we land features and bug-fixes on `dev`, they require us cutting a full release before they can be tested by interested/affected parties. Thanks to work done in #2202 and #2323, we now have just enough automation in our release pipeline to take care of some of the necessary work for building these releases. With some follow-up work, we can have these triggered through: - [Manual triggers] through CircleCI - [Scheduled pipeline] runs in CircleCI [Scheduled pipeline]: https://circleci.com/docs/scheduled-pipelines/ [Manual triggers]: https://circleci.com/docs/triggers-overview/#run-a-pipeline-from-the-circleci-web-app This work touches on ideas from #229 and #242, though neither of those issues are _directly_ "build nightly releases", though I did suggest it in my comments on one of them.
7 tasks
abernix
added a commit
that referenced
this pull request
Jan 20, 2023
Today, when we land features and bug-fixes on `dev`, they require us cutting a full release before they can be tested by interested/affected parties. Thanks to work done in #2202 and #2323, we now have just enough automation in our release pipeline to take care of some of the necessary work for building these releases. With this work, we can have these triggered through: - [Manual triggers] through CircleCI - [Scheduled pipeline] runs in CircleCI [Scheduled pipeline]: https://circleci.com/docs/scheduled-pipelines/ [Manual triggers]: https://circleci.com/docs/triggers-overview/#run-a-pipeline-from-the-circleci-web-app This touches on ideas from #229 and #242, though neither of those issues are _directly_ "build nightly releases", though I did suggest nightlies in my comments on one of them. Overall, this creates Router versions of the format `v0.0.0-nightly+YYYYMMDD.COMMIT_HASH`, which look roughly like `router-v0.0.0-nightly+20220102.abcd1234-x86_64-unknown-linux-gnu.tar.gz` as binaries on CircleCI Artifacts. In the future, we can attach these to GitHub Releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automate the release:
cargo xtask release prepare --help Finished dev [unoptimized + debuginfo] target(s) in 0.08s Running `xtask/target/debug/xtask release prepare --help` xtask-release-prepare 1.4.0 Prepare a new release USAGE: xtask release prepare [FLAGS] [version] FLAGS: --current-branch Release from the current branch rather than creating a new one --dry-run Dry run, don't commit the changes and create the PR -h, --help Prints help information --skip-license-ckeck Skip the license check -V, --version Prints version information ARGS: <version> The new version that is being created OR to bump (major|minor|patch|current) bryn@amsterdam ~/git/router bryn/automate-release You can create a new minor release by running.
To review please check:
42dc28a
Has everything it needs.
As part of this xtask was removed from the root workspace.