Docs: Add a disclaimer for users who set up health-checks and prometheus endpoints in a containers environment.#2194
Merged
o0Ignition0o merged 5 commits intodevfrom Dec 2, 2022
Merged
Conversation
…eus endpoints in a containers environment. fixes #2079 The health check and the prometheus endpoint listen to 127.0.0.1 by default. While this is a safe default, it prevents other pods from performing healthchecks and scrapping prometheus data. This behavior and customization is now documented.
This comment has been minimized.
This comment has been minimized.
garypen
approved these changes
Dec 2, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
Some small suggestions feel free to ignore the second two.
Co-authored-by: Gary Pennington <gary@apollographql.com>
Co-authored-by: Gary Pennington <gary@apollographql.com>
Co-authored-by: Gary Pennington <gary@apollographql.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: Add a disclaimer for users who set up health-checks and prometheus endpoints in a containers environment.
fixes #2079
The health check and the prometheus endpoint listen to 127.0.0.1 by default. While this is a safe default, it prevents other pods from performing healthchecks and scrapping prometheus data. This behavior and customization is now documented.