Wait for current tracer provider to shutdown when dropping telemetry#2191
Merged
Wait for current tracer provider to shutdown when dropping telemetry#2191
Conversation
We spawn a detached thread currently. That's probably not a good idea since the router may terminate before the thread terminates and that will likely cause spans to be lost. Let's join the thread in the `drop` and then print a warning message if there is an issue.
bnjjj
reviewed
Dec 2, 2022
added 3 commits
December 2, 2022 10:51
@bnjjj suggested adding a timeout during code review and that is what this does.
bnjjj
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We spawn a detached thread currently. That's probably not a good idea since the router may terminate before the thread terminates and that will likely cause spans to be lost.
Let's wait for the shutdown for up to 5 seconds in the
dropand then print a warning message if there is an issue.The figure of 5 seconds is not configurable, but could be made so in future if required.