Added Apollo Tracing support for @defer.#2190
Merged
Conversation
BrynCooke
force-pushed
the
bryncooke/defer-tracing
branch
from
b77af19 to
5003bb9
Compare
BrynCooke
commented
Dec 1, 2022
xtask/src/commands/compliance.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
Added this option to allow us to run tests until we have upgraded the project for new cargo about.
BrynCooke
commented
Dec 1, 2022
apollo-router/tests/snapshots/integration_tests__traced_basic_composition.snap
Outdated
Show resolved
Hide resolved
You can now view traces in Apollo Studio as normal. Fixes #1600
BrynCooke
force-pushed
the
bryncooke/defer-tracing
branch
from
6de4977 to
85356d4
Compare
bnjjj
approved these changes
Dec 2, 2022
Geal
reviewed
Dec 2, 2022
added 3 commits
December 2, 2022 10:40
Fix missing variables that were: 1. being serialized incorrectly when being placed on a span. 2. being searched for in the request span rather than the supergraph Make tests better by using insta redaction. Fixes #2186
garypen
approved these changes
Dec 2, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
Just one question. The span stuff is hairy, but I think the changes might have cleaned things up there.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now view traces in Apollo Studio as normal.
Fixes #1600
The main file to review is: apollo-router/src/plugins/telemetry/mod.rs
I've added a bunch of testing, but have not enhanced the jaeger test as I think we want to use tracing test for this.