Merged
Conversation
This comment has been minimized.
This comment has been minimized.
goto-bus-stop
force-pushed
the
apollo-parser-update
branch
from
a9793c7 to
daf8299
Compare
garypen
pushed a commit
that referenced
this pull request
Nov 30, 2022
the change from `impl From` to `impl TryFrom<$ParserType> for $RustType` affects the router. previously `parse_value` could panic because of apollo-parser, now it will just return None if the inputs are wrong. there are now two versions of apollo-encoder in the dep tree, until apollographql/introspector-gadget#5 is merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the change from
impl Fromtoimpl TryFrom<$ParserType> for $RustTypeaffects the router. previouslyparse_valuecould panic because of apollo-parser, now it will just return None if the inputs are wrong.there are now two versions of apollo-encoder in the dep tree, until apollographql/introspector-gadget#5 is merged