stabilize Redis caching for APQ and query plan#2176
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Geal
changed the title
bnjjj
approved these changes
Nov 30, 2022
BrynCooke
previously requested changes
Nov 30, 2022
Contributor
BrynCooke
left a comment
BrynCooke
left a comment
There was a problem hiding this comment.
Not requesting change, just blocking until we have confirmed license key decision.
Geal
force-pushed
the
geal/remove-cache-feature
branch
2 times, most recently
from
76d0dce to
7dbfaac
Compare
added 4 commits
December 2, 2022 10:54
settling on this pattern now should prevent any risk of injection in the future
Geal
force-pushed
the
geal/remove-cache-feature
branch
from
7dbfaac to
ec9df69
Compare
Contributor
Author
|
I rebased this PR to only leave the bug fixes and marking code as license key functionality |
BrynCooke
approved these changes
Dec 2, 2022
Contributor
BrynCooke
left a comment
BrynCooke
left a comment
There was a problem hiding this comment.
A nice to have followup is some spans around each of the cache layers.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.