Conversation
This comment has been minimized.
This comment has been minimized.
Closed
Geal
reviewed
Dec 15, 2022
SimonSapin
reviewed
Dec 15, 2022
Geal
approved these changes
Dec 16, 2022
garypen
reviewed
Dec 16, 2022
Contributor
garypen
left a comment
There was a problem hiding this comment.
Huge amount of work. Really well done!!
Did you check the diffs of the documentation for public changes? Could you please document the result in the PR so we can see what has been added?
apollo-router-scaffold/templates/plugin/src/plugins/{{snake_name}}.rs
Outdated
Show resolved
Hide resolved
Contributor
|
Here's a list of API changes: https://gist.github.com/BrynCooke/590941cc0008dabd40703aca3e9b4e6b |
Contributor
Author
|
@BrynCooke thanks a lot for the diff this looks good doesn't it? do we see things that went public and shouldnt ? |
BrynCooke
reviewed
Dec 16, 2022
…me}}.rs Co-authored-by: Gary Pennington <gary@apollographql.com>
garypen
approved these changes
Dec 16, 2022
2 tasks
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1496 eventually.
todo:
impl TryFrom<supergraph::Request> for Requestshould put the graphql::Request in the body if the method is POST, and urlencode it in the path if the method is GETfrom_supergraph_mock_callback_and_configurationand the likes, let's maybe use a builder