Skip to content

request retries are deactivated by default on mutations#2160

Merged
Geal merged 4 commits intodevfrom
geal/disallow-retry-on-mutation
Nov 28, 2022
Merged

request retries are deactivated by default on mutations#2160
Geal merged 4 commits intodevfrom
geal/disallow-retry-on-mutation

Conversation

@Geal
Copy link
Contributor

@Geal Geal commented Nov 25, 2022

Fix #2154
Follow up on #2006

@Geal Geal requested a review from StephenBarlow as a code owner November 25, 2022 14:20
@github-actions

This comment has been minimized.

@Geal Geal requested review from garypen and o0Ignition0o November 25, 2022 14:21
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but also think retry_mutations is a better name.

@Geal
Copy link
Contributor Author

Geal commented Nov 28, 2022

Approving but also think retry_mutations is a better name.
same

@Geal Geal enabled auto-merge (squash) November 28, 2022 12:29
@Geal Geal merged commit 5792c1f into dev Nov 28, 2022
@Geal Geal deleted the geal/disallow-retry-on-mutation branch November 28, 2022 12:46
garypen pushed a commit that referenced this pull request Nov 30, 2022
@BrynCooke BrynCooke added this to the v1.5.0 milestone Dec 3, 2022
@garypen garypen added this to the v1.5.0 milestone Dec 5, 2022
@BrynCooke BrynCooke modified the milestone: v1.5.0 Dec 5, 2022
@BrynCooke BrynCooke mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to deactivate subgraph request retries for mutations

4 participants