Merged
Conversation
BrynCooke
force-pushed
the
bryn/yaml-config-guidance
branch
from
cde31c6 to
9093b12
Compare
bnjjj
reviewed
Nov 25, 2022
Contributor
bnjjj
left a comment
bnjjj
left a comment
There was a problem hiding this comment.
I think you should also provide guidance to use supergraph instead of router and so one. That might be helpful
BrynCooke
requested review from
Geal,
SimonSapin,
abernix,
garypen and
o0Ignition0o
Geal
suggested changes
Nov 28, 2022
Contributor
|
maybe add one part about avoiding negative options ie plugin:
disable: trueWe run regularly into those and they always make things confusing |
Co-authored-by: Geoffroy Couprie <geoffroy@apollographql.com>
Co-authored-by: Geoffroy Couprie <geoffroy@apollographql.com>
Co-authored-by: Geoffroy Couprie <geoffroy@apollographql.com>
Co-authored-by: Geoffroy Couprie <geoffroy@apollographql.com>
Co-authored-by: Geoffroy Couprie <geoffroy@apollographql.com>
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@iomentum.com>
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@iomentum.com>
…ollo Router developers.
Contributor
Author
|
Guidance on negative options was added in 2f3193a |
Geal
approved these changes
Dec 6, 2022
bnjjj
reviewed
Dec 7, 2022
Contributor
bnjjj
left a comment
bnjjj
left a comment
There was a problem hiding this comment.
It looks good ! I'm just concern about checking these rules every time, unfortunately it's not automated but we should all be careful about this when reviewing a PR
bnjjj
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2158