feat(chart): Add the ability to mount the supergraph schema#2107
Closed
toneill818 wants to merge 3 commits intoapollographql:devfrom
Closed
feat(chart): Add the ability to mount the supergraph schema#2107toneill818 wants to merge 3 commits intoapollographql:devfrom
toneill818 wants to merge 3 commits intoapollographql:devfrom
Conversation
|
@toneill818: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
|
Hi @toneill818. Thanks for submitting this PR. I've thought about it a little and I think this is worthwhile enhancement, but I'd like to tweak it a little bit so that it makes use of existing chart volume mount capabilities rather than modifying the deployment template. The tweak is in PR: #2119 Let me know what you think. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to mount a supergraph with a configmap. If
supergraphFileit will create a configmap namedrouter-supergraph. It will also mount the supergraph and pass in the--supergraphoption in the command line arguments. This makes it easy to use helm'sset-fileoption to load a supergraph.Example:
helm upgrade --install --set-file supergraphFile supergraph.graphql [RELEASE_NAME] oci://ghcr.io/apollographql/helm-charts/routerThis command will set the value ofsupergraphFilethe contents ofsupergraph.graphqland when the pod gets created it will mount the configmap and load the supergraph's schema.