Skip to content

feat(chart): Add the ability to mount the supergraph schema#2107

Closed
toneill818 wants to merge 3 commits intoapollographql:devfrom
toneill818:dev
Closed

feat(chart): Add the ability to mount the supergraph schema#2107
toneill818 wants to merge 3 commits intoapollographql:devfrom
toneill818:dev

Conversation

@toneill818
Copy link
Contributor

Added the ability to mount a supergraph with a configmap. If supergraphFile it will create a configmap named router-supergraph. It will also mount the supergraph and pass in the --supergraph option in the command line arguments. This makes it easy to use helm's set-file option to load a supergraph.

Example: helm upgrade --install --set-file supergraphFile supergraph.graphql [RELEASE_NAME] oci://ghcr.io/apollographql/helm-charts/router This command will set the value of supergraphFile the contents of supergraph.graphql and when the pod gets created it will mount the configmap and load the supergraph's schema.

@apollo-cla
Copy link

@toneill818: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@garypen
Copy link
Contributor

garypen commented Nov 16, 2022

Hi @toneill818. Thanks for submitting this PR. I've thought about it a little and I think this is worthwhile enhancement, but I'd like to tweak it a little bit so that it makes use of existing chart volume mount capabilities rather than modifying the deployment template.

The tweak is in PR: #2119 Let me know what you think.

@toneill818
Copy link
Contributor Author

@garypen That looks good to me. Closing this PR in favor of PR #2119.

@toneill818 toneill818 closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants