Merged
Conversation
added 2 commits
November 14, 2022 14:04
No tests yet, to be done...
also fix the initial implementation to make sure all the tests are passing.
added 2 commits
November 14, 2022 16:26
with correct PR number
garypen
requested review from
BrynCooke,
Geal and
o0Ignition0o
and removed request for
a team and
BrynCooke
BrynCooke
reviewed
Nov 15, 2022
added 2 commits
November 15, 2022 10:19
to make clear why we don't use `process_error()` in `run_rhai_service()`.
BrynCooke
approved these changes
Nov 15, 2022
added 3 commits
November 15, 2022 10:37
Geal
approved these changes
Nov 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enhance the existing rhai error handling implementation so that specific status codes can be set.
The change is fully backwards compatible (i.e.: the existing method still works), but if a user wishes to specify the HTTP status code set in the client response, they need only
throwan objectmap as per the examples in NEXT_CHANGELOG.md.fixes: #2023