Skip to content

missing @skip and @include implementation for root operations#2096

Merged
Geal merged 3 commits intodevfrom
geal/top-level-skip-include
Nov 15, 2022
Merged

missing @skip and @include implementation for root operations#2096
Geal merged 3 commits intodevfrom
geal/top-level-skip-include

Conversation

@Geal
Copy link
Contributor

@Geal Geal commented Nov 14, 2022

Fix #2072

@skip and @include were not implemented for inline fragments and fragment spreads on top level operations

@Geal Geal requested review from BrynCooke and bnjjj November 14, 2022 16:14
@github-actions

This comment has been minimized.

@Geal Geal changed the title missing skip and include implementation for root operations missing @skip and @include implementation for root operations Nov 14, 2022
@Geal Geal self-assigned this Nov 14, 2022
@Geal Geal added this to the v1-NEXT milestone Nov 14, 2022
Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>
@Geal Geal enabled auto-merge (squash) November 15, 2022 09:29
@Geal Geal merged commit 066fb06 into dev Nov 15, 2022
@Geal Geal deleted the geal/top-level-skip-include branch November 15, 2022 09:46
@abernix abernix removed this from the v1-NEXT milestone Nov 15, 2022
@abernix abernix mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot return null for non-nullable field when using @include directive

3 participants