Skip to content

fix: Fix float input default value coercion on big integers #2090

Merged
abernix merged 6 commits intodevfrom
igni/64_bits_int
Nov 11, 2022
Merged

fix: Fix float input default value coercion on big integers #2090
abernix merged 6 commits intodevfrom
igni/64_bits_int

Conversation

@o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented Nov 11, 2022

Fix Float input-type coercion for default values with values larger than 32-bits (Issue #2087)

A regression has been fixed which caused the Router to reject integers larger than 32-bits used as the default values on Float fields in input types.

In other words, the following will once again work as expected:

input MyInputType {
    a_float_input: Float = 9876543210
}

By @o0Ignition0o in #2090

Fixes #2087

@github-actions

This comment has been minimized.

@o0Ignition0o o0Ignition0o changed the title failing test case for float default value fix: Fix float input default value coercion on big integers Nov 11, 2022
@o0Ignition0o o0Ignition0o marked this pull request as ready for review November 11, 2022 09:28
@o0Ignition0o o0Ignition0o requested a review from a team November 11, 2022 09:28
@o0Ignition0o o0Ignition0o self-assigned this Nov 11, 2022
@o0Ignition0o o0Ignition0o requested review from Geal and SimonSapin and removed request for a team November 11, 2022 09:28
@abernix abernix requested review from BrynCooke and removed request for Geal and SimonSapin November 11, 2022 09:30
@abernix abernix enabled auto-merge (squash) November 11, 2022 09:41
@abernix abernix merged commit cfef8c0 into dev Nov 11, 2022
@abernix abernix deleted the igni/64_bits_int branch November 11, 2022 09:57
@abernix abernix mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run the router that has a 64 bits integer as float default value

4 participants