fix: Fix float input default value coercion on big integers #2090
Merged
fix: Fix float input default value coercion on big integers #2090
Conversation
This comment has been minimized.
This comment has been minimized.
nmoutschen
approved these changes
Nov 11, 2022
BrynCooke
approved these changes
Nov 11, 2022
abernix
approved these changes
Nov 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Floatinput-type coercion for default values with values larger than 32-bits (Issue #2087)A regression has been fixed which caused the Router to reject integers larger than 32-bits used as the default values on
Floatfields in input types.In other words, the following will once again work as expected:
By @o0Ignition0o in #2090
Fixes #2087