update docker files to take advantage of aarch64 binaries#2085
Merged
Conversation
also: - cleanup dockerfiles so that we don't do binary copying between images - change base image from distroless to debian:bullseye-slim - unify 3 dockerfiles into 2
garypen
requested review from
SimonSapin and
bnjjj
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
bnjjj
approved these changes
Nov 10, 2022
As per team feedback.
abernix
approved these changes
Nov 15, 2022
Member
abernix
left a comment
abernix
left a comment
There was a problem hiding this comment.
changelog grooming, but LGTM! 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
o0Ignition0o
approved these changes
Nov 15, 2022
o0Ignition0o
approved these changes
Nov 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also:
note: we no longer build "debug" images because the base image is now a "debug" image (i.e.: it provides a shell we can use for investigating issues). The image has grown by about 50%, but I think it's a reasonable compromise to get away from the
libz.so.1hackery.