Skip to content

Update logging.mdx#2067

Merged
Geal merged 2 commits intoapollographql:devfrom
Cameronjmayfield:Cameronjmayfield-logging-mdx-typo
Nov 9, 2022
Merged

Update logging.mdx#2067
Geal merged 2 commits intoapollographql:devfrom
Cameronjmayfield:Cameronjmayfield-logging-mdx-typo

Conversation

@Cameronjmayfield
Copy link
Contributor

Simple typo fix from reqwest_logging to request_logging

Fix variable name
@apollo-cla
Copy link

@Cameronjmayfield: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@Geal
Copy link
Contributor

Geal commented Nov 9, 2022

reqwest is a rust http client so this line was about log filtering for that particular library so it is not a typo. But that library is not used anymore for subgraph requests though, so you could remove that entire line instead 😄

Remove reference to `reqwest_tracing` in the documentation as it is no longer used.
@Cameronjmayfield
Copy link
Contributor Author

Thanks @Geal! I've updated the MR.

@Geal
Copy link
Contributor

Geal commented Nov 9, 2022

Thanks!

@Geal Geal merged commit 0cd1bb7 into apollographql:dev Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants