Conversation
abernix
requested review from
BrynCooke,
Geal,
bnjjj,
garypen and
o0Ignition0o
abernix
commented
Nov 8, 2022
| name: release-name-router | ||
| labels: | ||
| helm.sh/chart: router-1.0.0-rc.5 | ||
| helm.sh/chart: router-1.0.0-rc.7 |
Member
Author
There was a problem hiding this comment.
These seem to be "extra" spaced out because the kubernetes.mdx was not updated during the last release.
abernix
commented
Nov 8, 2022
Geal
approved these changes
Nov 9, 2022
Co-authored-by: Gary Pennington <gary@apollographql.com>
bnjjj
reviewed
Nov 9, 2022
garypen
approved these changes
Nov 9, 2022
BrynCooke
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the appropriate changes in preparation for releasing. As a slight divergence from the previous release's methodology, this PR doesn't directly target
main, thereby avoiding the conflation of the "release preparation" from the actual merge. Instead, this PR merge into a1.3.0branch that itself will targetmain(and is the #2069 PR in draft mode), but is currently a snapshot of what is intended to merge tomain.My claim that this will slightly improve the reviewability of the commit by separating the two. On the "Down" side, it requires two PRs. Feedback on this approach more than welcome.
This PR's commits:
NEXT_CHANGELOG.mdto top ofCHANGELOG.mdCHANGELOG.mdprior to initial review (the bulk of the work)