do not expose the trace_id in response header right now#2061
Merged
Conversation
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
abernix
reviewed
Nov 8, 2022
Member
abernix
left a comment
There was a problem hiding this comment.
In the same spirit, should we hold off on returning it in the traces to Apollo Studio since it that won't be an accurate representation of what headers were actually returned?
router/apollo-router/src/plugins/telemetry/tracing/apollo_telemetry.rs
Lines 430 to 436 in 48780c4
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Contributor
Author
|
@abernix I commented the part related to studio too |
Geal
approved these changes
Nov 8, 2022
o0Ignition0o
approved these changes
Nov 8, 2022
Contributor
o0Ignition0o
left a comment
There was a problem hiding this comment.
I think the ci issue is because we need to bump the version (the fuzzer is relying on a yanked crate)
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.