(fix) #2036 Otel default endpoint incorrectly uses https.#2048
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
BrynCooke
force-pushed
the
bryn/otel-tls-defaulting
branch
from
ad30151 to
c6105b0
Compare
open-telemetry/opentelemetry-rust#908 default endpoint is now configured to use http rather than https. In addition, tls domain will only be set if the endpoint scheme is https. If the endpoint port is 443 a warning is displayed if TLS has not been configured.
BrynCooke
force-pushed
the
bryn/otel-tls-defaulting
branch
from
c6105b0 to
df128ae
Compare
o0Ignition0o
approved these changes
Nov 7, 2022
bnjjj
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in otel open-telemetry/opentelemetry-rust#908 that did not manifest until
tls-rootswas enabled ontonic.This PR introduces a workaround until this is fixed upstream.
default endpoint is now configured to use http rather than https. In addition, tls domain will only be set if the endpoint scheme is https.
If the endpoint port is 443 ta warning is displayed if TLS has not been configured.