Merged
Conversation
traffic shaping layers tend to require clonable services and a specific ordering, so we apply them manually instead of relying on Plugin::subgraph_service, which only works on BoxService and has no ordering guarantee
This comment has been minimized.
This comment has been minimized.
4 tasks
Contributor
|
Is there a way we could extend the existing functionality around plugins ordering to allow traffic shaping to be moved to last? If this would work then I think it'd be cleaner. |
Contributor
Author
|
we could, but the service it manipulates would still be a |
BrynCooke
approved these changes
Nov 7, 2022
bnjjj
reviewed
Nov 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin infrastructure works on
BoxServiceinstances, and makes no guarantee on plugin ordering.The traffic shaping plugin needs a clonable inner service, and should run right before calling
the underlying service. So this changes the traffic plugin application so it can work directly
on the underlying service. It is still a plugin though, so it keeps the same configuration.