reload the configuration when receiving the SIGHUP signal#2015
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
bnjjj
approved these changes
Oct 27, 2022
garypen
suggested changes
Oct 27, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
Looks good. One small NIT.
Co-authored-by: Gary Pennington <gary@apollographql.com>
garypen
approved these changes
Oct 27, 2022
Contributor
Author
|
so I suspect SIGHUP is used by the CI to stop tests so they fail 😅 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #35
This adds support for reloading configuration when receiving the SIGHUP signal. This only works on unix-like platforms, and only with the configuration file