Conversation
Deal with all the changes in APIs. 1. Metrics have changed significantly. Traits have been introduced, so we can now have cleaner integration otel and expose a regular Meter even though we are aggregating under the hood. 2. We can't actually update yet as we need open-telemetry/opentelemetry-rust#894 to land in a release. The ability to send spans to multiple exporters has been removed accidentally from JaegerCollector.
This comment has been minimized.
This comment has been minimized.
BrynCooke
force-pushed
the
bryn/otel-upgrade
branch
from
c859971 to
9afe24e
Compare
BrynCooke
force-pushed
the
bryn/otel-upgrade
branch
6 times, most recently
from
9455d02 to
aa17ac8
Compare
BrynCooke
force-pushed
the
bryn/otel-upgrade
branch
from
aa17ac8 to
0330367
Compare
added 5 commits
October 20, 2022 10:32
Note that it is the otel_layer that converts otel.kind to an enum, and it is case-insensitive, so the snaps are correct.
BrynCooke
force-pushed
the
bryn/otel-upgrade
branch
2 times, most recently
from
41eab1d to
86c5a79
Compare
BrynCooke
force-pushed
the
bryn/otel-upgrade
branch
from
86c5a79 to
eaacca2
Compare
BrynCooke
requested review from
a team,
bnjjj and
garypen
and removed request for
a team
|
Are there plans to get this merged soon? I build with Bazel that relies on all dependencies to be predicted/provided to the build for hermeticity and this update to the opentelemetry library fixes a complex |
BrynCooke
force-pushed
the
bryn/otel-upgrade
branch
from
a3170e8 to
82db907
Compare
Contributor
Author
|
@bazaglia The issue has been that the latest otel release broke our Jager integration and there hasn't been another release since. I just figured out a workaround though so maybe we can get this over the line. |
Closed
Added docs for batch_processor Added changelog.
added 2 commits
December 8, 2022 14:15
bnjjj
suggested changes
Dec 8, 2022
bazaglia
reviewed
Dec 8, 2022
bnjjj
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deal with all the changes in APIs from the OtelUpgrade and other miscellaneous improvements.
Metrics have changed significantly. Traits have been introduced, so we can now have cleaner integration otel and expose a regular Meter even though we are aggregating under the hood.
We can't actually update yet as we need
build_exporterforopentelemetry-jaegerCollectorPipelineopen-telemetry/opentelemetry-rust#894 to land in a release. The ability to send spans to multiple exporters has been removed accidentally from JaegerCollector.Closes #1948
tracesIgnoredis detected.