Skip to content

docs: add a note about --dev mode config equivalent#1940

Merged
abernix merged 4 commits intoapollographql:devfrom
lennyburdette:patch-5
Nov 7, 2022
Merged

docs: add a note about --dev mode config equivalent#1940
abernix merged 4 commits intoapollographql:devfrom
lennyburdette:patch-5

Conversation

@lennyburdette
Copy link
Contributor

@lennyburdette lennyburdette commented Oct 10, 2022

To actively discourage folks from using --dev in production, this explains how to cherry-pick parts of dev mode for a production config.

cc @BrynCooke

@lennyburdette
docs: add a note about --dev mode config equivalent
d457bc9 
To actively discourage folks from using `--dev` in production, this explains how to cherry-pick parts of dev mode for a production config.

cc @BrynCooke
StephenBarlow
StephenBarlow approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@StephenBarlow StephenBarlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with edit suggestion!

Would like us to review the preview before we merge to make sure I didn't screw up the blockquote (which I'm using in place of markdown > because it's a nightmare with a codeblock)

@lennyburdette lennyburdette changed the base branch from main to dev October 11, 2022 14:07
@abernix @StephenBarlow
Apply suggestions from code review
4fedc6a 
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
@abernix
Copy link
Member

abernix commented Oct 25, 2022

@StephenBarlow I landed your great suggested changes, but I'm not sure how to validate your request to examine the Deploy Preview because the Netlify build seems to be failing for what I believe are unrelated reasons:

11:43:04 AM: error UNHANDLED REJECTION Couldn't find temp query result for "/404/".
11:43:04 AM: 
11:43:04 AM:   Error: Couldn't find temp query result for "/404/".

seen here in the logs, specifically

@abernix abernix self-assigned this Oct 25, 2022
@abernix abernix added the documentation Improvements or additions to documentation label Oct 25, 2022
@abernix abernix merged commit 6b2bd9f into apollographql:dev Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrynCooke BrynCooke BrynCooke approved these changes

+1 more reviewer

@StephenBarlow StephenBarlow StephenBarlow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abernix abernix

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lennyburdette @abernix @BrynCooke @StephenBarlow