Changes to IntoHeaderName and IntoHeaderValue#1607
Merged
SimonSapin merged 2 commits intomainfrom Aug 25, 2022
Merged
Conversation
SimonSapin
force-pushed
the
simon/http-types
branch
from
e3253ac to
abe919e
Compare
Contributor
Author
|
CI failed twice in a row with a doctest linking error (but on different doctests) that doesn’t reproduce on my machine. Signal 9 is sigkill, could the CI worker be running out of memory? I’ve seen linking be surprisingly memory-hungry on Linux, and it’s possible that doctests being compiled in parallel end up linking at the same time. |
Contributor
Author
|
Circle-CI has a new "Resources" tab
|
See changelog
This will hopefully help avoid OOM while linking many doctests in parallel.
SimonSapin
force-pushed
the
simon/http-types
branch
from
521f7ba to
58c2c3c
Compare
o0Ignition0o
approved these changes
Aug 25, 2022
Contributor
o0Ignition0o
left a comment
o0Ignition0o
left a comment
There was a problem hiding this comment.
One question, the rest lgtm.
| fn eq(&self, other: &Self) -> bool { | ||
| match (&self.result, &other.result) { | ||
| (Ok(a), Ok(b)) => a == b, | ||
| (Err(_), Err(_)) => true, |
Contributor
There was a problem hiding this comment.
Why are two invalid headers equal?
What you wrote here looks like an Eq implementation, PartialEq being (Err(_), Err(_)) => false,?
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changelog