Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,11 @@ members = [
# debug = false
strip = "debuginfo"
incremental = false

# Temporary patch to async-compression
# It is used by tower-http's CompressionLayer. The compression code was not handling
# the Poll::Pending result from the underlying stream, so it was accumulating the
# entire compressed response in memory before sending it, which creates issues with
# deferred responses getting received too late
[patch.crates-io]
async-compression = { git = 'https://github.com/geal/async-compression', branch = 'encoder-flush' }
8 changes: 8 additions & 0 deletions NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,14 @@ next chunk to see the delimiter.

By [@Geal](https://github.com/Geal) in https://github.com/apollographql/router/pull/1596

### Patch async-compression to compress responses in streaming ([PR #1604](https://github.com/apollographql/router/issues/1604))

async-compression is a dependency used for response compression. Its implementation accumulates the entire compressed response
in memory before sending it, which creates problems for deferred responses, where we want the responses to come as soon as
possible, and not all at once after a while.

By [@Geal](https://github.com/Geal) in https://github.com/apollographql/router/pull/1604

## 🛠 Maintenance

### Depend on published `router-bridge` ([PR #1613](https://github.com/apollographql/router/issues/1613))
Expand Down