terminate the router when a panic occurs#1602
Merged
Conversation
We have a panic handler that logs a backtrace when a panic is encountered. Many panic situations result in the router becoming unusable. We should terminate the router once we have finished writing panic details to the log.
This comment has been minimized.
This comment has been minimized.
bnjjj
reviewed
Aug 24, 2022
and fix my comment typo
bnjjj
approved these changes
Aug 24, 2022
o0Ignition0o
approved these changes
Aug 24, 2022
This was referenced Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a panic handler that logs a backtrace when a panic is
encountered. Many panic situations result in the router becoming
unusable. We should terminate the router once we have finished
writing panic details to the log.