Change verbosity of state machine logs to trace#1597
Merged
Conversation
This changes the verbosity of messages like `transitioned to starting` from the `info` level to the `trace` level since messages about the state machine aren't necessary user-facing information during normal operation. Closes #1578
This comment has been minimized.
This comment has been minimized.
abernix
commented
Aug 24, 2022
| }; | ||
|
|
||
| tracing::info!("transitioned to {}", &new_state); | ||
| tracing::trace!("transitioned to {}", &new_state); |
Member
Author
There was a problem hiding this comment.
@o0Ignition0o seemed okay with debug in his comment on the original issue. I considered it.
My claim would be that it's better to make things more verbose if necessary and bury as much extra distraction as we can unless it's proven consistently necessary to make it louder at less-noisy levels.
abernix
requested review from
bnjjj,
garypen and
o0Ignition0o
and removed request for
garypen
bnjjj
approved these changes
Aug 24, 2022
o0Ignition0o
approved these changes
Aug 24, 2022
garypen
approved these changes
Aug 24, 2022
Contributor
|
I think we can merge this once the NEXT_CHANGELOG conflict is dealt with |
Geal
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the verbosity of messages like
transitioned to startingfromthe
infolevel to thetracelevel since messages about the state machinearen't necessary user-facing information during normal operation.
I waffled a bit on whether this should be
traceordebug. To some degree this seems like deeper inards of the Router than most people should ever need to encounter. Since I think debugging the state machine might be a a particularly detailed operation in the general sense, I chose to usetracesince it's my undersatnding the user can still use other log/env filters to tune the scope of what they're receiving log messages for, even at thetracelevel.Anyway, I'm happy to change it to
debug— just say the word.Closes #1578