Skip to content

fix(apollo-router): fix typo in error message #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
o0Ignition0o merged 2 commits into from
Aug 24, 2022
Merged

fix(apollo-router): fix typo in error message #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec6a861
fix(apollo-router): fix typo in error message
nmoutschen Aug 24, 2022
0867367
chore: add changelog entry
nmoutschen Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ Move the location of the `text` field when exposing the query plan and fill it w

By [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/1557

### Fix typo on HTTP errors from subgraph ([#1593](https://github.com/apollographql/router/pull/1593))

Remove the closed parenthesis at the end of error messages resulting from HTTP errors from subgraphs.

By [@nmoutschen](https://github.com/nmoutschen) in https://github.com/apollographql/router/pull/1593


## 🛠 Maintenance
## 📚 Documentation
4 changes: 2 additions & 2 deletions apollo-router/src/services/subgraph_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl tower::Service<crate::SubgraphRequest> for SubgraphService {
return Err(BoxError::from(FetchError::SubrequestHttpError {
service: service_name.clone(),
reason: format!(
"subgraph HTTP status error '{}': {})",
"subgraph HTTP status error '{}': {}",
parts.status,
String::from_utf8_lossy(&body)
),
Expand Down Expand Up @@ -475,7 +475,7 @@ mod tests {
.unwrap_err();
assert_eq!(
err.to_string(),
"HTTP fetch failed from 'test': subgraph HTTP status error '400 Bad Request': BAD REQUEST)"
"HTTP fetch failed from 'test': subgraph HTTP status error '400 Bad Request': BAD REQUEST"
);
}

Expand Down