Make http_ext::Request and http_ext::Response private#1589
Merged
o0Ignition0o merged 1 commit intomainfrom Aug 24, 2022
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Use types from the http crate instead in a number of places. Part of #1553
SimonSapin
force-pushed
the
simon/http-types
branch
from
44c61b4 to
8743d69
Compare
garypen
approved these changes
Aug 24, 2022
Contributor
o0Ignition0o
left a comment
o0Ignition0o
left a comment
There was a problem hiding this comment.
LGTM
I m merging this in an hour, unless someone else is raising concerns :)
bnjjj
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use types from the http crate instead in a number of places.
Part of #1553