migrate cors configuration from server to top level#1586
Merged
Conversation
from: ``` server: cors: ``` to: ``` cors: ``` All the "live" code is working fine, the errors are in the test code which I've not updated until we agree this issue is worth addressing. fixes: #1483
This comment has been minimized.
This comment has been minimized.
added 2 commits
August 26, 2022 09:37
garypen
changed the title
SimonSapin
approved these changes
Aug 26, 2022
Contributor
SimonSapin
left a comment
SimonSapin
left a comment
There was a problem hiding this comment.
The licenses.html changes look unrelated?
Looks good other than this
Contributor
Author
I think it is unrelated. I can revert it. |
Seems like a spurious change, so reverting...
Geal
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from:
to:
fixes: #1483