Conversation
…e query plan has been cached Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
bnjjj
requested review from
BrynCooke,
Geal,
SimonSapin,
garypen and
o0Ignition0o
and removed request for
garypen
This comment has been minimized.
This comment has been minimized.
abernix
previously requested changes
Aug 19, 2022
Member
abernix
left a comment
abernix
left a comment
There was a problem hiding this comment.
Ah! nice find!
Could we add some tests to catch this?
Geal
approved these changes
Aug 19, 2022
Contributor
Geal
left a comment
Geal
left a comment
There was a problem hiding this comment.
damn, I did it for the errors but forgot for the main case 😢
Contributor
|
++ for a test, I've added one to the query plan exposition by invoking the service twice, this would probably work |
garypen
approved these changes
Aug 19, 2022
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Merged
Member
thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was introduced with the cache on the query planner and then we didn't have any correct data for usage reporting.