Merged
Conversation
deferred response should return payloads in an array in the response's `incremental` field
This comment has been minimized.
This comment has been minimized.
Geal
requested review from
garypen and
o0Ignition0o
and removed request for
o0Ignition0o
Contributor
Author
|
reference: graphql/defer-stream-wg#41 |
o0Ignition0o
suggested changes
Aug 19, 2022
Contributor
o0Ignition0o
left a comment
o0Ignition0o
left a comment
There was a problem hiding this comment.
A slight worry about the requirements around incremental, and 1 question about snapshots. otherwise lgtm
| extensions: Default::default(), | ||
| subselection: Default::default(), | ||
| has_next: Default::default(), | ||
| ..Response::default() |
| impl Response { | ||
| /// Constructor | ||
| #[builder(visibility = "pub")] | ||
| #[allow(clippy::too_many_arguments)] |
Contributor
Author
There was a problem hiding this comment.
here the lint was still complaining, unfortunately :/
Contributor
There was a problem hiding this comment.
interesting, we should open an issue
o0Ignition0o
approved these changes
Aug 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1548
deferred response should return payloads in an array in the response's
incrementalfield