Skip to content

implement map_response for deferred responses in rhai #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Geal merged 10 commits into from
Aug 22, 2022
Merged

implement map_response for deferred responses in rhai #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
962d032
implement map_deferred_response in rhai
Aug 12, 2022
32c047f
Merge branch 'main' into geal/map_deferred_response
Aug 16, 2022
9897190
factor some code
Aug 16, 2022
d64abb9
changelog
Aug 16, 2022
4774dfc
Merge branch 'main' into geal/map_deferred_response
Aug 18, 2022
33cbf52
use map_response for deffered responses too
Aug 18, 2022
e352cbe
add the headers_are_available function
Aug 18, 2022
bc8165c
Merge branch 'main' into geal/map_deferred_response
Aug 19, 2022
22b59b0
use default function implementations throwing an error
Aug 19, 2022
58f1e7c
Merge branch 'main' into geal/map_deferred_response
Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,16 @@ See the API documentation for an example. (It can be built with `cargo doc --ope

By [@SimonSapin](https://github.com/SimonSapin)

### Remove telemetry configuration hot reloading ([PR #1501](https://github.com/apollographql/router/pull/1501))

The `map_deferred_response` method is now available for the router service and execution
service in Rhai. When using the `@defer` directive, we get the data in a serie of graphql
responses. The first one is available with the `map_response` method, where the HTTP headers
and the response body can be modified. The following responses are available through
`map_deferred_response`, which only has access to the response body.

By [@geal](https://github.com/geal) in https://github.com/apollographql/router/pull/1501

## 🐛 Fixes

### Variables validation: return a 400 if variables validation fails ([#1403](https://github.com/apollographql/router/issues/1403))
Expand Down
Loading