Give a reachable public path to some items#1461
Merged
SimonSapin merged 2 commits intomainfrom Aug 8, 2022
Merged
Conversation
… that were only public through appearing in other APIs. Part of #1305
Contributor
|
@SimonSapin your pull request is missing a changelog! |
garypen
reviewed
Aug 4, 2022
| use crate::graphql::Response; | ||
| use crate::json_ext::Path; | ||
| use crate::json_ext::Value; | ||
| pub use crate::reload::Error as ReloadError; |
Contributor
There was a problem hiding this comment.
This makes me sad... This is part of the code we copied from tracing_subscriber and is another good reason why we should get rid of our hot reload for tracing stuff...
Contributor
Author
There was a problem hiding this comment.
Good news! #1463 removes this type entirely
BrynCooke
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… that were only public through appearing in other APIs.
Part of #1305