Conversation
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
…feat_rate_limit_timeout
…graphql/router into bnjjj/feat_rate_limit_timeout
…graphql/router into bnjjj/feat_rate_limit_timeout
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
…graphql/router into bnjjj/feat_rate_limit_timeout
…feat_rate_limit_timeout
…feat_rate_limit_timeout
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
|
in the changelog it says
how is the client identified? is that configurable? totally fine if these are future features, i was just curious. (are we planning to eventually support something like https://docs.konghq.com/hub/kong-inc/rate-limiting/?) |
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
|
@lennyburdette it's mistake it's not rate limited for a specific client. But yes if it's a needed/asked feature we could implement that kind of behavior in the future. |
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
|
Since this is a global rate limit suggest and we'll likely want to support per client rate limiting in the future suggest using |
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Geoffroy Couprie <geoffroy@apollographql.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
…hql/router into bnjjj/feat_rate_limit_timeout
|
the lower (millisecond) and upper(u64::MAX milliseconds) limits of the rate limit window should be documented, no? |
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
close #946
close #1184
close #1275
related to #338
Additions to the traffic shaping plugin:
example of configuration:
Rate limit algorithm is coming from https://dev.to/satrobit/rate-limiting-using-the-sliding-window-algorithm-5fjn and https://medium.com/@intmainco/design-a-scalable-rate-limiting-algorithm-system-design-nlogn-895abba44b77