Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

[Q] React native @apollo/react-hooks has unmet peer dependency react-dom #3704

Open
Grohden opened this issue Nov 20, 2019 · 0 comments · May be fixed by #3783
Open

[Q] React native @apollo/react-hooks has unmet peer dependency react-dom #3704

Grohden opened this issue Nov 20, 2019 · 0 comments · May be fixed by #3783

Comments

@Grohden
Copy link

Grohden commented Nov 20, 2019

Not a bug actually, but I've noticed that @apollo/react-hooks includes react-dom as a peerDependency, is this correct?

I'm using it with react-native, so I probably should not have react-dom installed (I think), also, there are some issues that maybe related to this question: #3394 and #3115, the last one says it's fixed, but
it isn't (?)

Note: react-apollo also lists react-dom as peerDependency:
[email protected]" has unmet peer dependency "react-dom@^15.0.0 || ^16.0.0"., is this correct too?

maclockard added a commit to maclockard/react-apollo that referenced this issue Jan 2, 2020
Fixes apollographql#3704 

Looked through all the files for this package and I didn't see any usage of `react-dom` so its unnecessary as a peer dep. I didn't check other packages, so its possible the peer dep is extraneous elsewhere as well.
@maclockard maclockard linked a pull request Jan 2, 2020 that will close this issue
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant