Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/poor-doors-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@apollo/federation-internals": patch
"@apollo/subgraph": patch
---

Revert change to @composeDirective definition to specify nullable argument value.

We cannot fix the definition as that would break customers using older versions of `subgraph-js`. Our validations are already verifying that the values are specified.
11 changes: 11 additions & 0 deletions .changeset/silly-olives-reflect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@apollo/composition": patch
---

Improve error messages when @composeDirective arguments are NULL or empty strings.

Previous message on undefined/null argument value
`Cannot read properties of undefined (reading '0')`

New message
`Argument to @composeDirective in subgraph "${sg.name}" cannot be NULL or an empty String`