Skip to content

Implement @cost and @listSize directives for demand control #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tninesling merged 14 commits into from
Jul 22, 2024
Merged

Implement @cost and @listSize directives for demand control #3074

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
977e021
Started implementation of new directives using merge strategy instead…
tninesling Jul 9, 2024
484db3f
Composition works, but extraction doesn't
tninesling Jul 9, 2024
680d07e
Cost argument definition extraction working for demand control direct…
tninesling Jul 9, 2024
0e29ce0
Carried over directive name mapping from other implementation, but th…
tninesling Jul 10, 2024
33e3627
Cost extraction for input fields
tninesling Jul 10, 2024
2ec9aa5
Cost extraction for enums
tninesling Jul 10, 2024
5f91e01
DRY things up a bit
tninesling Jul 10, 2024
2fb41eb
Create changeset
tninesling Jul 10, 2024
b7b63b2
Test hints
tninesling Jul 10, 2024
670bfc2
Disallow composing cost and listSize
tninesling Jul 10, 2024
e26a614
Add test for link import mismatch
tninesling Jul 11, 2024
5365478
Add cost and listSize to full import link statement
tninesling Jul 11, 2024
bb512c6
Add argument merger tests for new nullable strategies
tninesling Jul 11, 2024
36d6c71
Handle multiple composable directives from the same spec (#3086)
tninesling Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/happy-bats-exist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@apollo/composition": minor
"@apollo/federation-internals": minor
---

Implements two new directives for defining custom costs for demand control. The `@cost` directive allows setting a custom weight to a particular field in the graph, overriding the default cost calculation. The `@listSize` directive gives the cost calculator information about how to estimate the size of lists returned by subgraphs. This can either be a static size or a value derived from input arguments, such as paging parameters.
Loading