Skip to content

Support @join__directive(graphs, name, args) directives #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamn merged 12 commits into from
Jan 12, 2024
Merged

Support @join__directive(graphs, name, args) directives #2894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
17ed6cb
Support `@join__directive(graphs, name, args)` directives.
benjamn Dec 19, 2023
a04d9c3
npx changeset
benjamn Dec 20, 2023
2b6228f
Compute map from import name to @link URL only once per Schema.
benjamn Jan 8, 2024
e4076f0
Indent `@source*` test schema template string like other tests.
benjamn Jan 8, 2024
928b294
Consistent quoting style.
benjamn Jan 8, 2024
d6f7e8a
Rename too-generic JSON scalar to TypenameKeyMap.
benjamn Jan 8, 2024
8127b69
Limit locations where `@join__directive` can appear.
benjamn Jan 8, 2024
d10a518
Specify minimumFederationVersion for new SourceSpecDefinition.
benjamn Jan 9, 2024
7c7486e
Add `@source*` directive getters to FederationMetadata.
benjamn Jan 9, 2024
d803501
Use FeatureUrl.parse instead of normalizeSpecIdentityURL.
benjamn Jan 8, 2024
59fd58f
Test more variations of `@join__directive` composition.
benjamn Jan 9, 2024
4a07c77
Make cspell accept SUBGRAPHC, like SUBGRAPHA and SUBGRAPHB.
benjamn Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/real-comics-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@apollo/composition": minor
"@apollo/federation-internals": minor
---

Support `@join__directive(graphs, name, args)` directives
1 change: 1 addition & 0 deletions .cspell/cspell-dict.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ subgpraph
subgrahs
SUBGRAPHA
SUBGRAPHB
SUBGRAPHC
subraph
subraphs
Substrat
Expand Down
4 changes: 4 additions & 0 deletions composition-js/src/__tests__/__snapshots__/compose.composeDirective.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ directive @join__unionMember(graph: join__Graph!, member: String!) repeatable on

directive @join__enumValue(graph: join__Graph!) repeatable on ENUM_VALUE

directive @join__directive(graphs: [join__Graph!], name: String!, args: join__DirectiveArguments) repeatable on SCHEMA | OBJECT | INTERFACE | FIELD_DEFINITION

directive @mytag(name: String!) repeatable on FIELD_DEFINITION | OBJECT | INTERFACE | UNION | ARGUMENT_DEFINITION | SCALAR | ENUM | ENUM_VALUE | INPUT_OBJECT | INPUT_FIELD_DEFINITION | SCHEMA

directive @tag(name: String!, prop: String!) on FIELD_DEFINITION | OBJECT
Expand All @@ -49,6 +51,8 @@ enum join__Graph {

scalar join__FieldSet

scalar join__DirectiveArguments

type Query
@join__type(graph: SUBGRAPHA)
@join__type(graph: SUBGRAPHB)
Expand Down
Loading