Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTel-JS broken link #1302

Merged

Conversation

MannyPamintuanWorkAccount
Copy link
Contributor

This PR does the following,

Updates the link to "Getting Started" to the most recent link provided in the OTel-JS Repo

This change in linking is documented in OTel-JS commit #2493

This PR does the following,

Updates the link to "Getting Started" to the [most recent link provided in the OTel-JS Repo](https://github.com/open-telemetry/opentelemetry-js/blob/main/README.md?plain=1#L5)

This change in linking is documented in OTel-JS [commit apollographql#2493](open-telemetry/opentelemetry-js#2493)
@apollo-cla
Copy link

@MannyPamintuanAtCare: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@MannyPamintuanWorkAccount
Copy link
Contributor Author

🚀 ✨ 🌕
Making the world a better place, one less broken link at a time.

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your 🌍 -improving hyperlink-awareness! LGTM.

(If you wanted to also do this on the main branch, that'd be much appreciated, but I can follow-up myself if not. 😉 )

@abernix abernix merged commit f7702b1 into apollographql:version-0.x Dec 13, 2021
MannyPamintuanWorkAccount added a commit to MannyPamintuanWorkAccount/federation that referenced this pull request Dec 13, 2021
Per @abernix's [great suggestion](apollographql#1302 (review)), this PR does the following,

- Updates the link to "Getting Started" to the [most recent link provided in the OTel-JS Repo](https://github.com/open-telemetry/opentelemetry-js/blob/main/README.md?plain=1#L5)
  - This change in linking is documented in OTel-JS [commit apollographql#2493](open-telemetry/opentelemetry-js#2493)
@MannyPamintuanWorkAccount
Copy link
Contributor Author

MannyPamintuanWorkAccount commented Dec 13, 2021

Thank you for your 🌍 -improving hyperlink-awareness! LGTM.

(If you wanted to also do this on the main branch, that'd be much appreciated, but I can follow-up myself if not. 😉 )

You're most welcome, Jesse (@abernix)!
I am more than happy to put in a PR for the main branch as well and have done so, ready for review at y'alls convenience. :)

@abernix
Copy link
Member

abernix commented Dec 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants