Add query planner configuration option generate_query_fragments#460
Merged
trevor-scheer merged 6 commits intocreate-pull-request/router-bridgefrom Mar 21, 2024
Merged
Conversation
dariuszkuc
approved these changes
Mar 21, 2024
trevor-scheer
force-pushed
the
trevor/generate-query-fragments
branch
2 times, most recently
from
e19da5d to
444d2d8
Compare
trevor-scheer
force-pushed
the
create-pull-request/router-bridge
branch
from
d29e0ab to
e222c0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: apollographql/federation#2958
Adopting this in router should take into consideration that both
reuse_query_fragmentsandgenerate_query_fragmentsshould not both be set to true. Sincereuse_currently defaults to true, it should be disabled whengenerate_is enabled.