Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better separation between config errors and composition errors #54

Open
EverlastingBugstopper opened this issue Mar 3, 2022 · 0 comments
Open

better separation between config errors and composition errors #54

EverlastingBugstopper opened this issue Mar 3, 2022 · 0 comments

Comments

@EverlastingBugstopper
Copy link
Contributor

builds are a multi-stage process. first the config file is resolved (get all the SDL from the various subgraphs) and THEN run composition afterwards. this means that BuildErrors will either be all config errors or all composition errors. currently we have that designation one layer under where I think we should have them. It'd be a better representation to have the error type on the BuildErrors type rather than the BuildError type.
dingxiangfei2009 pushed a commit to dingxiangfei2009/federation-rs that referenced this issue Jun 23, 2022
@garypen
Add a basic health check to the router (apollographql#252)
7afbd7d 
* Add a basic health check to the router

Provide a health check endpoint which behaves in the same way as the
health check on the gateway.

At this point in time it always returns pass because we don't have a
different health status to set.

resolves: apollographql#54
dingxiangfei2009 pushed a commit to dingxiangfei2009/federation-rs that referenced this issue Jun 23, 2022
@o0Ignition0o
release v0.1.0-alpha.3 (apollographql#314)
ba50765 
# [v0.1.0-alpha.3] 2022-01-11

## 🚀🌒 Public alpha release

> An alpha or beta release is in volatile, active development. The release might not be feature-complete, and breaking API changes are possible between individual versions.

## ✨ Features

- Trace sampling [apollographql#228](apollographql/router#228): Tracing each request can be expensive. The router now supports sampling, which allows us to only send a fraction of the received requests.

- Health check [apollographql#54](apollographql/router#54)

## 🐛 Fixes

- Schema parse errors [apollographql#136](apollographql/router#136): The router wouldn't display what went wrong when parsing an invalid Schema. It now displays exactly where a the parsing error occurred, and why.

- Various tracing and telemetry fixes [apollographql#237](apollographql/router#237): The router wouldn't display what went wrong when parsing an invalid Schema. It now displays exactly where a the parsing error occurred, and why.

- Query variables validation [apollographql#62](apollographql/router#62): Now that we have a schema parsing feature, we can validate the variables and their types against the schemas and queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EverlastingBugstopper