Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor commands to use ink #1697

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Refactor commands to use ink #1697

wants to merge 32 commits into from

Conversation

JakeDawkins
Copy link
Contributor

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins mentioned this pull request Dec 4, 2019
Closed
@JakeDawkins JakeDawkins force-pushed the jbaxleyiii/ink-test branch 2 times, most recently from 95279c6 to f236e06 Compare December 12, 2019 14:17
@zionts zionts mentioned this pull request Dec 18, 2019
Closed
4 tasks
Adam Zionts and others added 26 commits January 10, 2020 10:35
@JakeDawkins
[WIP] Add graph info command
8681b33 
This will be used to help CLI users understand the current composition
information about the graph
@JakeDawkins
wip add graph:info command
6aac7eb
@JakeDawkins
Return only the compositionResult
0433641
@JakeDawkins
Expand query to include more graph information
a40ef70 
This is likely a broken commit, but signing off for the night to resume
work tomorrow. The plan is for the `graph:info` command to be just as
useful to non-federation users as to federation users, and this commit
updates the types and the query to include more graph-level information
@JakeDawkins
Add type safety and silly error
c4e83a3
@JakeDawkins
Start adding support for non-federated graphs
b2b5e5a
@JakeDawkins
Add in information from query
818fe7e
@JakeDawkins
Remove extra print (unnecessary)
595acc6
@JakeDawkins
wip
5ed5095
@JakeDawkins
fix build
c376a5d
@JakeDawkins
remove graph:info
ae3d919
@JakeDawkins
remove graph info engine file
bda6486
@JakeDawkins
add file
d7ec4ed
@JakeDawkins
Add WindowOrWorkerGlobalScope to apollo-env
29c6b36
@JakeDawkins
work
f448808
@JakeDawkins
further work on the poc of ink
bdb2840
@JakeDawkins
remove double sorting
5cbac1a
@JakeDawkins
remove double sorting
d7b4fa5
@JakeDawkins
start testing service:list
d23bc9b
@JakeDawkins
add config building to new command
071e318
@JakeDawkins
update comments attempt to test Command
983a794
@JakeDawkins
update command test
3be3e9c
@JakeDawkins
Add tests for NewCommand
3b22c2d
@JakeDawkins
add client command support to base class
1ddbbaf
@JakeDawkins
add task list and newextract command
0f8645d
@JakeDawkins
wip on download-schema
9c5c931
@ryanwilsonperkin
Copy link

Thanks for your work on this draft! It helped point me to where Oclif is doing some custom things with the TS configuration for files. I've opened oclif/config#96 to add support for .tsx files out of the box, would appreciate any feedback on it if you're able to get it working with this branch.

@fmvilas fmvilas mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeDawkins @ryanwilsonperkin