Invalid non-nullable or required List Type variable should return UserInputError

[zeroshine]

The original way handle required or non-nullable UserInputError is not considering List Type variable. It returns INTERNAL_SERVER_ERROR instead of BAD_USER_INPUT

The result of query

query ( x: [String]!) {
  hello(x:$x)
}

is

{
  errors: [
    {
      message: "Variable "$x" of required type "[String]!" was not provided.",
      extensions: {
        code: "INTERNAL_SERVER_ERROR"
      }
    }
  ]
}

should be

{
  errors: [
    {
      message: "Variable "$x" of required type "[String]!" was not provided.",
      extensions: {
        code: "BAD_USER_INPUT"
      }
    }
  ]
}

check node type and replace message.startWith with message.match to handle List type and single variable

[apollo-cla]

@zeroshine: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[IvanGoncharov]

Can you please use startsWith?
Passing client-controlled values into RegExp is bad practice(even if they are sanitized by GraphQL parser) because it can lead to ReDoS.

Also can you please extract this check in separate function (e.g. isBadUserInputGraphQLError) that checks if GraphQLError matches?

[zeroshine]

fix in 863fe02

[IvanGoncharov]

I think it's ok as a temporary solution until AS4 and ready to merge.

cc @glasser

[glasser]

Looks good. I rebased, added a test of another case I was curious about, and added a CHANGELOG.

Hopefully we will eventually be able to rely on a fix to graphql/graphql-js#3169 instead of doing this heuristic.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5abf963:

Sandbox	Source
Apollo Server Typescript	Configuration
Apollo Server	Configuration