Fix dependency issue when using @rollup/plugin-commonjs

[DSergiu]

@rollup/plugin-commonjs has a hard time with this dependency and results in "undefined error" since gql is used before it is defined in the bundled code.

One can argue that the fix should be in the rollup plugin, but it is a tricky fix, and historically there were many attempts to solve it with no complete success.

[apollo-cla]

@DSergiu: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[glasser]

Is there an easy way to add "build with rollup" to our CI so that we don't reintroduce issues like this?

It would be nice to only have one import of the symbol in our code base. How about moving the import to packages/apollo-server-core/src/gql.ts, re-exporting from that file from index.ts, and importing from that file in the schema reporter file?

[DSergiu]

Is there an easy way to add "build with rollup" to our CI so that we don't reintroduce issues like this?

It would be nice to only have one import of the symbol in our code base. How about moving the import to packages/apollo-server-core/src/gql.ts, re-exporting from that file from index.ts, and importing from that file in the schema reporter file?

👍 Sure thing. I did extract gql into gql.ts and added a unit test which executes the es6 bundle with rolllup + commonjs.

To replicate the issue, import gql from index.ts import { gql } from '../..'; inside schemaReporter.js and run the test and you should get:

TypeError: (0 , __1.gql) is not a function

[glasser]

Worth noting that I believe this works because our npm pretest script builds the package ahead of time.

[glasser]

Thanks, this looks good! We'll do our best to keep rollup working.