fix: add getter for field Symbol.toStringTag whose absence causes Typ… #5663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eScript errors in GraphQL.js 16
Contributor
|
@n1ru4l Thanks for pointing it out. |
Contributor
|
Closing as this is no longer relevant thanks mostly in part to @IvanGoncharov's work on #6355. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eScript errors in GraphQL.js 16
I am not 100% sure whether this is actually needed. It is mandatory in GraphQL.js 16.0.0-rc.1, but a comment on the source code indicates it should be removed. I notified GraphQL.js maintainers of that.
https://github.com/n1ru4l/graphql-js/blob/4493ca3d1281e01635570824f70867aa68610323/src/error/GraphQLError.ts#L204-L207
Depending on how graphql/graphql-js#3245 (comment) is answered it might not be necessary to merge this.
Note: This would probably be easier to solve if ApolloError just extends from GraphQLError instead, but I guess there are reasons for not doing this that I am not aware of.