Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-reg and response-cache: only export in one way #5542

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

glasser
Copy link
Member

@glasser glasser commented Jul 23, 2021

For some reason, these plugins defined their exports both using export default and module.exports =. In practice this means that the latter
overrides the former or something, which in some contexts causes
problems (see #5526).

For some reason, these plugins defined their exports both using `export
default` and `module.exports =`. In practice this means that the latter
overrides the former or something, which in some contexts causes
problems (see #5526).
@glasser glasser force-pushed the glasser/only-one-export-method branch from bebb018 to b4264b3 Compare July 23, 2021 21:20
@glasser glasser added this to the MM-2021-07 milestone Jul 23, 2021
@glasser glasser mentioned this pull request Jul 23, 2021
@glasser glasser merged commit fbfba5a into release-3.1.0 Jul 23, 2021
@glasser glasser deleted the glasser/only-one-export-method branch July 23, 2021 21:40
@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants