-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Federated Schemas From Existing Schema #4310
Conversation
@trevor-scheer Could you share some thoughts / direction on what the next steps here would be? We discussed the idea of switching to It is my belief that, since |
Just for reference, I currently don't have time to work on this anymore, but i did copy j's orignal branch here : https://github.com/Superd22/apollo-server/tree/build-from-schema-2 |
Usage of |
any progress on this? |
Hi @trevor-scheer, I'm interested in picking up this PR. I've taken a look at: #4313 I'm willing to fix the merge requests and tests as I would really love to have this feature 👍 |
Just wondering if there's any updates to this PR? Would definitely love to have the ability to reuse existing schema |
@mengqing Actually, the code for this PR no longer lives in this repository. It's in the https://github.com/apollographql/federation/ repository now. We've also extracted the parts of I'm going to close this PR since it's definitely not going to get merged in this repo :) @trevor-scheer can advise as to whether or not it's likely that a new PR to add |
This re-opens @j's #3013, which was closed inadvertently by the process described in #4304. 😭 Since the source branch had been deleted, it was one of only a couple PRs I couldn't re-open. Thus, this new PR needs to be created.
(To be clear: I certainly don't mean to take credit for it. This is purely organizational/housekeeping. I re-opened it by pulling the ref that GitHub stores on
refs/pull/3013/head
(the old PR; still exists even when the PR author removes the branch) usinggit fetch origin pull/3013/head && git checkout -b re-open-j-3013 FETCH_HEAD && git push origin
✨ )