⚠️ Update the default branch of the Apollo Server repository. #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more permanent anyways.
According to the documentation for `package.json` (referenced below), this is the correct way to reference packages that live within a monorepo within the `package.json`. Ref: https://docs.npmjs.com/files/package.json#repository
Historically, there have been a few varieties chosen here, but we should keep them all the same now that we have a standard that has emerged!
This PR will result in a release being created for this repository.
|
Well, that did not work as expected. When this PR merged, many PRs were re-targeted, but most were closed. I've contacted GitHub Support and am going to open a pinned issue. EDIT: Fixed! See #4304 for details. |
|
did I miss any april's fools? |
|
I'm curious, what was this change for? |
|
don't say it out loud, but probably has to do with this rare movement that thinks the word "master" refers to slavery. |
|
@gentunian you hit the mark. Git and GitHub are reportedly also moving towards releasing an update where this will become standard after said update. It's a |
|
Thanks, for sure changing branches naming will make this world a better place. Glad to see this coming. |
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
This PR will result in a release being created for this repository. Apollo-Orig-Commit-AS: apollographql/apollo-server@aa22b2c
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…l/master Apollo-Orig-Commit-AS: apollographql/apollo-server@a2d2792
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default branch of this repository to
mainfrom its previous name,master. While this could be done exclusively in the UI (and that change has been made already), this is being opened as a PR for a few reasons:With the recent introduction of automatic pull-request retargeting by GitHub, this will happen automatically when this PR is merged.
I've pushed the housekeeping commits to make this change whole to the (no longer default!)
masterbranch which this PR is opened from. There are a couple additional changes which I've put into this PR, mainly around alignment of patterns within this repository and adopting thedirectorynotation withinpackage.json'srepositoryspecifications. See the individual commits for details.